lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 01 Dec 2013 10:35:23 +0100 From: Johannes Berg <johannes@...solutions.net> To: Joe Perches <joe@...ches.com> Cc: Chen Gang <gang.chen.5i5j@...il.com>, "John W. Linville" <linville@...driver.com>, rkuo <rkuo@...eaurora.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, David Miller <davem@...emloft.net>, linux-wireless@...r.kernel.org, netdev <netdev@...r.kernel.org> Subject: Re: [PATCH] net: mac80211: tx.c: be sure of 'sdata->vif.type' must be NL80211_IFTYPE_AP when be in NL80211_IFTYPE_AP case On Sat, 2013-11-30 at 12:39 -0800, Joe Perches wrote: > +++ b/net/mac80211/tx.c > @@ -1777,18 +1777,16 @@ netdev_tx_t ieee80211_subif_start_xmit(struct sk_buff *skb, > } > ap_sdata = container_of(sdata->bss, struct ieee80211_sub_if_data, > u.ap); > - chanctx_conf = rcu_dereference(ap_sdata->vif.chanctx_conf); > - if (!chanctx_conf) > - goto fail_rcu; > - band = chanctx_conf->def.chan->band; > - if (sta) > - break; > /* fall through */ > case NL80211_IFTYPE_AP: > - if (sdata->vif.type == NL80211_IFTYPE_AP) > - chanctx_conf = rcu_dereference(sdata->vif.chanctx_conf); > + chanctx_conf = rcu_dereference(ap_sdata->vif.chanctx_conf); Good try, but no, now ap_sdata isn't even assigned. :) johannes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists