linux-kernel - Re: [PATCH] PCI: export MSI mode using attributes, not kobjects

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 2 Dec 2013 18:24:06 -0700
From:	Bjorn Helgaas <bhelgaas@...gle.com>
To:	Greg KH <greg@...ah.com>
Cc:	Veaceslav Falico <vfalico@...hat.com>,
	Neil Horman <nhorman@...driver.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Yinghai Lu <yinghai@...nel.org>,
	Knut Petersen <Knut_Petersen@...nline.de>,
	Ingo Molnar <mingo@...nel.org>,
	Paul McKenney <paulmck@...ux.vnet.ibm.com>,
	Frédéric Weisbecker <fweisbec@...il.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] PCI: export MSI mode using attributes, not kobjects

On Fri, Nov 29, 2013 at 10:53 AM, Greg KH <greg@...ah.com> wrote:
> On Fri, Nov 29, 2013 at 10:41:37AM +0100, Veaceslav Falico wrote:
>> On Wed, Nov 27, 2013 at 10:46:52AM -0800, Greg Kroah-Hartman wrote:
>> >From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>> >
>> >The PCI MSI sysfs code is a mess with kobjects for things that don't
>> >really need to be kobjects.  This patch creates attributes dynamically
>> >for the MSI interrupts instead of using kobjects.
>> >
>> >Note, this removes a directory from the current MSI interrupt sysfs
>> >code:
>> >
>> >old MSI kobjects:
>> >pci_device
>> >   └── msi_irqs
>> >       └── 40
>> >           └── mode
>> >
>> >new MSI attributes:
>> >pci_device
>> >   └── msi_irqs
>> >       └── 40
>> >
>> >As there was only one file "mode" with the kobject model, the interrupt
>> >number is now a file that returns the "mode" of the interrupt (msi vs.
>> >msix).
>> >
>> >Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>>
>> Works like a charm for me.
>>
>> FWIW,
>>
>> Reviewed-by: Veaceslav Falico <vfalico@...hat.com>
>
> On Thu, Nov 28, 2013 at 10:14:19PM -0500, Neil Horman wrote:
>> ACK, Testing with git-head irqbalance on F19 with this patch and it works fine.
>>
>> Thanks!
>> Acked-by: Neil Horman <nhorman@...driver.com>
>
> Great, thanks for both of you testing this.
>
> Bjorn, any objection to take this through your tree for 3.14-rc1?

Nope, I don't object at all.  We probably should update
Documentation/ABI/testing/sysfs-bus-pci at the same time, though.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/