linux-kernel - Re: [PATCH] blackfin: bf60x: clock: return 0 upon error from clk_round

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 3 Dec 2013 10:34:52 +0800
From:	Steven Miao <realmz6@...il.com>
To:	Paul Walmsley <pwalmsley@...dia.com>
Cc:	Bob Liu <lliubbo@...il.com>, Mike Frysinger <vapier@...too.org>,
	"uclinux-dist-devel@...ckfin.uclinux.org" 
	<uclinux-dist-devel@...ckfin.uclinux.org>,
	"open list:CAN NETWORK DRIVERS <linux-can@...r.kernel.org>, open
	list:NETWORKING DRIVERS <netdev@...r.kernel.org>, open list" 
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] blackfin: bf60x: clock: return 0 upon error from clk_round_rate()

Hi Paul,

Applied to next 3.14 tree. Thanks!

On Wed, Nov 27, 2013 at 9:00 AM, Paul Walmsley <pwalmsley@...dia.com> wrote:
>
> clk_round_rate() should return 0 upon an error, rather than returning
> a negative error code.  This is because clk_round_rate() is being
> changed to return an unsigned return type rather than a signed type,
> since some clock sources can generate rates higher than (2^31)-1 Hz.
>
> Signed-off-by: Paul Walmsley <pwalmsley@...dia.com>
> Cc: Steven Miao <realmz6@...il.com>
> Cc: Bob Liu <lliubbo@...il.com>
> Cc: Mike Frysinger <vapier@...too.org>
> ---
> Applies on v3.13-rc1.  See also:
>
> http://marc.info/?l=linux-arm-kernel&m=138542591313620&w=2
>
>  arch/blackfin/mach-bf609/clock.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/blackfin/mach-bf609/clock.c
> b/arch/blackfin/mach-bf609/clock.c
> index dab8849af884..3f5323d3e116 100644
> --- a/arch/blackfin/mach-bf609/clock.c
> +++ b/arch/blackfin/mach-bf609/clock.c
> @@ -131,7 +131,7 @@ EXPORT_SYMBOL(clk_get_rate);
>
>  long clk_round_rate(struct clk *clk, unsigned long rate)
>  {
> -       long ret = -EIO;
> +       long ret = 0;
>         if (clk->ops && clk->ops->round_rate)
>                 ret = clk->ops->round_rate(clk, rate);
>         return ret;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/