linux-kernel - Re: [PATCH] perf/x86: fix bug in event constraint end marker macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 4 Dec 2013 10:03:36 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Stephane Eranian <eranian@...gle.com>
Cc:	linux-kernel@...r.kernel.org, mingo@...e.hu, peterz@...radead.org,
	ak@...ux.intel.com, jolsa@...hat.com, zheng.z.yan@...el.com
Subject: Re: [PATCH] perf/x86: fix bug in event constraint end marker macro


* Stephane Eranian <eranian@...gle.com> wrote:

>  #define EVENT_CONSTRAINT_END		\
> -	EVENT_CONSTRAINT(0, 0, 0)
> +	{ .idxmsk64 = 0,		\
> +	  .code = 0,			\
> +	  .cmask = 0,			\
> +	  .weight = -1,			\
> +	  .overlap = 0,			\
> +	  .flags = 0,			\
> +}

A nit, simply writing:

#define EVENT_CONSTRAINT_END { .weight = -1, }

... should be enough as initialization to zero is guaranteed for the 
other fields.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/