linux-kernel - Re: [PATCH 7/7] usb: phy-tegra-usb.c: wrong pointer check for remap UTMI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 04 Dec 2013 10:02:23 +0800
From:	Chris Ruehl <chris.ruehl@...ys.com.hk>
To:	Chris Ruehl <chris.ruehl@...ys.com.hk>
CC:	balbi@...com, gregkh@...uxfoundation.org, swarren@...dotorg.org,
	thierry.reding@...il.com, linux-usb@...r.kernel.org,
	linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 7/7] usb: phy-tegra-usb.c: wrong pointer check for remap
 UTMI

Sorry for the noise, it should be [PATCH] only .. I will resend it.


On Wednesday, December 04, 2013 10:00 AM, Chris Ruehl wrote:
> usb: phy-tegra-usb.c: wrong pointer check for remap UTMI
>
> A wrong pointer was used to test the result of devm_ioremap()
>
> Signed-off-by: Chris Ruehl<chris.ruehl@...ys.com.hk>
> Acked-by: Venu Byravarasu<vbyravarasu@...dia.com>
> ---
>   drivers/usb/phy/phy-tegra-usb.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-tegra-usb.c
> index 82232ac..bbe4f8e 100644
> --- a/drivers/usb/phy/phy-tegra-usb.c
> +++ b/drivers/usb/phy/phy-tegra-usb.c
> @@ -876,7 +876,7 @@ static int utmi_phy_probe(struct tegra_usb_phy *tegra_phy,
>
>   	tegra_phy->pad_regs = devm_ioremap(&pdev->dev, res->start,
>   		resource_size(res));
> -	if (!tegra_phy->regs) {
> +	if (!tegra_phy->pad_regs) {
>   		dev_err(&pdev->dev, "Failed to remap UTMI Pad regs\n");
>   		return -ENOMEM;
>   	}

-- 
GTSYS Limited RFID Technology
A01 24/F Gold King Industrial Bld
35-41 Tai Lin Pai Road, Kwai Chung, Hong Kong
Fax (852) 8167 4060 - Tel (852) 3598 9488

Disclaimer: http://www.gtsys.com.hk/email/classified.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/