linux-kernel - Re: [PATCH v5 1/5] watchdog: davinci: change driver to use WDT core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 4 Dec 2013 12:48:18 -0800
From:	Guenter Roeck <linux@...ck-us.net>
To:	Ivan Khoronzhuk <ivan.khoronzhuk@...com>
Cc:	Santosh Shilimkar <santosh.shilimkar@...com>,
	linux-arm-kernel@...ts.infradead.org, mark.rutland@....com,
	wim@...ana.be, nsekhar@...com, linux-watchdog@...r.kernel.org,
	devicetree@...r.kernel.org, Pawel.Moll@....com,
	swarren@...dotorg.org, ijc+devicetree@...lion.org.uk,
	galak@...nel.crashing.org, rob.herring@...xeda.com,
	linux-kernel@...r.kernel.org, grant.likely@...aro.org,
	grygorii.strashko@...com
Subject: Re: [PATCH v5 1/5] watchdog: davinci: change driver to use WDT core

On Wed, Dec 04, 2013 at 09:39:26PM +0200, Ivan Khoronzhuk wrote:
> To reduce code duplicate and increase code readability use WDT core
> code to handle WDT interface.
> 
> Remove io_lock as the WDT core uses mutex to lock each wdt device.
> Remove wdt_state as the WDT core tracks state with its own variable.
> 
> The watchdog_init_timeout() can read timeout value from timeout-sec
> property if the passed value is out of bounds. The heartbeat is
> initialized in next way. If heartbeat is not set thought module
> parameter, try to read it's value from WDT node timeout-sec property.
> If node has no one, use default value.
> 
> The heartbeat is hold in wdd->timeout by WDT core, so use it in
> order to set timeout period.
> 
> Acked-by: Santosh Shilimkar <santosh.shilimkar@...com>
> Reviewed-by: Guenter Roeck <linux@...ck-us.net>
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@...com>

Looks good, except you did not explain ...

>  
> -	dev_info(dev, "heartbeat %d sec\n", heartbeat);
> +	watchdog_set_nowayout(wdd, 1);
>  
why nowayout is enforced.

Thanks,
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/