linux-kernel - Re: [PATCH] crash_dump: fix compilation error (on MIPS at least)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 4 Dec 2013 16:30:17 -0500
From:	Vivek Goyal <vgoyal@...hat.com>
To:	Qais Yousef <qais.yousef@...tec.com>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Michael Holzheu <holzheu@...ux.vnet.ibm.com>,
	linux-mips@...ux-mips.org, stable@...r.kernel.org
Subject: Re: [PATCH] crash_dump: fix compilation error (on MIPS at least)

On Wed, Dec 04, 2013 at 03:58:22PM +0000, Qais Yousef wrote:
>   In file included from kernel/crash_dump.c:2:0:
>   include/linux/crash_dump.h:22:27: error: unknown type name ‘pgprot_t’
> 
> when CONFIG_CRASH_DUMP=y
> 
> The error was traced back to this commit:
> 
>   9cb218131de1 vmcore: introduce remap_oldmem_pfn_range()
> 
> include <asm/pgtable.h> to get the missing definition

pgprot_t definition for mips seems to be in asm/page.h. So why are you
including asm/pgtable.h and not asm/page.h? For other architectures it
seems to be in other files. That means those arch will have broken
compilation now. 

So question is, is there any arch specific file which one can include
and be covered for pgprot_t definition for all the arches.

Thanks
Vivek

> 
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Michael Holzheu <holzheu@...ux.vnet.ibm.com>
> Cc: Vivek Goyal <vgoyal@...hat.com>
> Cc: <linux-mips@...ux-mips.org>
> Cc: <stable@...r.kernel.org> # 3.12
> Reviewed-by: James Hogan <james.hogan@...tec.com>
> Signed-off-by: Qais Yousef <qais.yousef@...tec.com>
> ---
> I haven't tried any other architecture except mips.
> If OK this should be considered for stable 3.12 (CCed).
> 
>  include/linux/crash_dump.h |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/crash_dump.h b/include/linux/crash_dump.h
> index fe68a5a..7032518 100644
> --- a/include/linux/crash_dump.h
> +++ b/include/linux/crash_dump.h
> @@ -6,6 +6,8 @@
>  #include <linux/proc_fs.h>
>  #include <linux/elf.h>
>  
> +#include <asm/pgtable.h> /* for pgprot_t */
> +
>  #define ELFCORE_ADDR_MAX	(-1ULL)
>  #define ELFCORE_ADDR_ERR	(-2ULL)
>  
> -- 
> 1.7.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/