linux-kernel - Re: [PATCH] Staging: TIDSPBRIDGE: Remove UUID helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 8 Dec 2013 13:32:05 +0100
From:	Pavel Machek <pavel@....cz>
To:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
Cc:	Ivajlo Dimitrov <ivo.g.dimitrov.75@...il.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	Ivaylo Dimitrov <freemangordon@....bg>, pali.rohar@...il.com,
	Joe Perches <joe@...ches.com>
Subject: Re: [PATCH] Staging: TIDSPBRIDGE: Remove UUID helper

Hi!

> > >> I guess the initial mail somehow didn't make it through your spam filter:
> > >> https://lkml.org/lkml/2013/12/1/70
> > > It did, but I thought that people asked for it to be changed in the
> > > thread afterwards, so I was expecting an updated version from you.
> > >
> > > Care to fix things up and resend it?
> > >
> > > thanks,
> > >
> > > greg k-h
> > 
> > Sure, the change I was asked for is trivial, but I didn't get the reason 
> > why it is needed. Neither there is a reply to my follow-up comment [0]. 
> > Sorry, I am pretty much new on LKML and could miss things that are 
> > supposed to be clear from the start, but my impression is that when 
> > someone says "it is better", he/she should explain why it is better or 
> > at least what is wrong with the patch he/she wants  to be changed.
> > 
> > However, I don't want to enter some arguing loop, so if you think I 
> > should change the code as per Joe's comment, just confirm it and I'll do it.
> 
> Please try.

Not checking sscanf() return is un-nice, so yes, it would be nice to
fix it, even if it will not happen in practice. 0 / -EINVAL is
acceptable return value.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/