linux-kernel - Re: [PATCH] xen/debugfs: Check debugfs initialization before using it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 8 Dec 2013 06:01:00 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	"ethan.zhao" <ethan.kernel@...il.com>
Cc:	konrad.wilk@...cle.com, raghavendra.kt@...ux.vnet.ibm.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xen/debugfs: Check debugfs initialization before using it

On Sun, Dec 08, 2013 at 07:31:02PM +0800, ethan.zhao wrote:
> Should check debugfs initialization with debugfs_initialized() before using it,
> Because if it isn't initialized, the return value of fake debugfs_create_dir() etc
> functions would be ERR_PTR(-ENODEV), checking with NULL will not work.

So?  It should "just work" without this check, right?  What happens if
your patch isn't applied and debugfs isn't enabled?

greg k-h

> Signed-off-by: ethan.zhao <ethan.kernel@...il.com>

Please put your "real" name here, not one with a '.' in it.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/