linux-kernel - Re: [PATCH] mm/zswap.c: add BUG() for default case in zswap_writeback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 09 Dec 2013 21:34:25 +0800
From:	Chen Gang <gang.chen.5i5j@...il.com>
To:	James Hogan <james.hogan@...tec.com>
CC:	Seth Jennings <sjenning@...ux.vnet.ibm.com>, linux-mm@...ck.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm/zswap.c: add BUG() for default case in zswap_writeback_entry()

On 12/09/2013 07:40 PM, James Hogan wrote:
> On 09/12/13 11:21, Chen Gang wrote:
>> Oh, I tried gcc 4.6.3-2 rhel version, get the same result as yours (do
>> not report warning), but for me, it is still a compiler's bug, it
>> *should* report a warning for it, we can try below:
> 
> Not necessarily. You can't expect the compiler to detect and warn about
> more complex bugs the programmer writes, so you have to draw the line
> somewhere.
> 

Yeah, we can not only depend on compiler to help us finding bugs.


> IMO missing some potential bugs is better than warning about code that
> isn't buggy since that just makes people ignore the warnings or
> carelessly try to silence them.
> 

I can understand, every members have their own taste, so this patch is
depended on related maintainers' taste (so kernel provided
"EXTRA_CFLAGS=-W" to satisfy some of guys taste -- e.g. me).  ;-)


Thanks
-- 
Chen Gang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/