linux-kernel - Re: [PATCH v2 01/15] mfd: menelaus: Drop _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 9 Dec 2013 10:14:22 -0600
From:	Felipe Balbi <balbi@...com>
To:	Lee Jones <lee.jones@...aro.org>
CC:	Felipe Balbi <balbi@...com>,
	Linux OMAP Mailing List <linux-omap@...r.kernel.org>,
	Aaro Koskinen <aaro.koskinen@....fi>, <sameo@...ux.intel.com>,
	Tony Lindgren <tony@...mide.com>,
	Linux ARM Kernel Mailing List 
	<linux-arm-kernel@...ts.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 01/15] mfd: menelaus: Drop __exit section annotation

Hi,

On Mon, Dec 09, 2013 at 09:37:48AM +0000, Lee Jones wrote:
> > > The code looks mostly fine, but the implementation of the commit logs
> > > seems lazy. Please submit a v3 using coherent sentences with full
> > > explanations and correct punctuation.
> > 
> > example ?
> 
> All of your commit messages.
> 
> > that macro just helps removing some extra
> 
>   ^- Sentences start with an uppercase character.
> 
> > line of code and hides ffs() calls.
> > 
> > while at that, also fix a variable shadowing
> 
>   ^- Sentences start with an uppercase character.
> 
> > bug where 'int irq' was being redeclared inside
> > inner loop while it was also argument to interrupt
> > handler.
> 
>   < ---------------   50 chars   ----------------- >
> 
> Please use the full 72 char (or there abouts) width of the buffer.

I don't see any mention of punctuation problems, however. Also, you're
not complaining about the content at all, which tells me those sentences
aren't as incoherent as you claimed before. But fair enough, I'll fix
those up and add Aaro's Tested-by

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)