linux-kernel - Re: [PATCH v2 6/7] mm/migrate: remove unused function, fail_migrate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 09 Dec 2013 12:07:26 -0500
From:	Naoya Horiguchi <n-horiguchi@...jp.nec.com>
To:	Joonsoo Kim <iamjoonsoo.kim@....com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Mel Gorman <mgorman@...e.de>, Rik van Riel <riel@...hat.com>,
	Rafael Aquini <aquini@...hat.com>,
	Christoph Lameter <cl@...ux.com>,
	Joonsoo Kim <js1304@...il.com>, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, Vlastimil Babka <vbabka@...e.cz>,
	Zhang Yanfei <zhangyanfei@...fujitsu.com>
Subject: Re: [PATCH v2 6/7] mm/migrate: remove unused function,
 fail_migrate_page()

On Mon, Dec 09, 2013 at 06:10:47PM +0900, Joonsoo Kim wrote:
> fail_migrate_page() isn't used anywhere, so remove it.
> 
> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@....com>

Reviewed-by: Naoya Horiguchi <n-horiguchi@...jp.nec.com>

> diff --git a/include/linux/migrate.h b/include/linux/migrate.h
> index e4671f9..4308018 100644
> --- a/include/linux/migrate.h
> +++ b/include/linux/migrate.h
> @@ -41,9 +41,6 @@ extern int migrate_page(struct address_space *,
>  extern int migrate_pages(struct list_head *l, new_page_t x,
>  		unsigned long private, enum migrate_mode mode, int reason);
>  
> -extern int fail_migrate_page(struct address_space *,
> -			struct page *, struct page *);
> -
>  extern int migrate_prep(void);
>  extern int migrate_prep_local(void);
>  extern int migrate_vmas(struct mm_struct *mm,
> @@ -83,7 +80,6 @@ static inline int migrate_huge_page_move_mapping(struct address_space *mapping,
>  
>  /* Possible settings for the migrate_page() method in address_operations */
>  #define migrate_page NULL
> -#define fail_migrate_page NULL
>  
>  #endif /* CONFIG_MIGRATION */
>  
> diff --git a/mm/migrate.c b/mm/migrate.c
> index cdafdc0..b595f89 100644
> --- a/mm/migrate.c
> +++ b/mm/migrate.c
> @@ -550,14 +550,6 @@ void migrate_page_copy(struct page *newpage, struct page *page)
>   *                    Migration functions
>   ***********************************************************/
>  
> -/* Always fail migration. Used for mappings that are not movable */
> -int fail_migrate_page(struct address_space *mapping,
> -			struct page *newpage, struct page *page)
> -{
> -	return -EIO;
> -}
> -EXPORT_SYMBOL(fail_migrate_page);
> -
>  /*
>   * Common logic to directly migrate a single page suitable for
>   * pages that do not use PagePrivate/PagePrivate2.
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@...ck.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@...ck.org"> email@...ck.org </a>
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/