linux-kernel - Re: [PATCH 14/14] tools lib traceevent: Get rid of die() in some string conversion funcitons

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 10 Dec 2013 10:50:38 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...nel.org>, Jiri Olsa <jolsa@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Namhyung Kim <namhyung.kim@....com>
Subject: Re: [PATCH 14/14] tools lib traceevent: Get rid of die() in some string conversion funcitons

On Mon, 9 Dec 2013 11:24:10 -0500, Steven Rostedt wrote:
> On Mon,  9 Dec 2013 14:34:11 +0900
> Namhyung Kim <namhyung@...nel.org> wrote:
>
>> @@ -2231,12 +2238,13 @@ static char *exp_to_str(struct event_filter *filter, struct filter_arg *arg)
>>  		op = "^";
>>  		break;
>>  	default:
>> -		die("oops in exp");
>> +		break;
>>  	}
>
> This looks like we silently ignored the warning. Perhaps we should have:
>
> 	default:
> 		op = "[ERROR IN EXPRESSION TYPE]";
> 		break;

Ah, looks better. :)

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/