linux-kernel - [PATCHSET driver-core-next] kernfs: implement kernfs_dir

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 11 Dec 2013 16:02:54 -0500
From:	Tejun Heo <tj@...nel.org>
To:	gregkh@...uxfoundation.org
Cc:	linux-kernel@...r.kernel.org, ebiederm@...ssion.com, kay@...y.org
Subject: [PATCHSET driver-core-next] kernfs: implement kernfs_dir_ops

Hello,

kernfs is now properly separated out from sysfs and can be used for
other pseudo filesystems too; however, there are still some missing
features - kernfs filesystems can't process any directory manipulation
systemcalls such as mkdir(2), rmdir(2) and rename(2), which cgroup,
one of the prospect kernfs users, requires for cgroup management.

This patchset implements those directory operation hooks so that
kernfs users can be hooked into those system calls and implement
appropriate actions, which may or may not match the actual semantics
of those syscalls.

The implementation is mostly straight forward except for one aspect.
sysfs, and thus kernfs, never allowed negative dentries.  They are
actively shot down and lookup callback assumes that there's no
negative dentries.  This doesn't really have a lot of benefits and
changing isn't difficult.  The lookup path simply needs to tell the
vfs layer that a full fresh lookup is necessary for negative dentries.

The patchset is lightly tested with sample module which implements
"test" filesystem with weird behaviors using kernfs (will be posted as
a reply to this message).  Note that the module needs kernfs APIs to
be exported.  It might be necessary that we might need further changes
to actually convert cgroup to kernfs but I think this should provide
pretty good basis.

This patchset contains the following six patches.

 0001-kernfs-add-mode-to-kernfs_create_dir-_ns.patch
 0002-kernfs-add-REMOVED-check-to-create-and-rename-paths.patch
 0003-kernfs-mark-static-names-with-KERNFS_STATIC_NAME.patch
 0004-kernfs-update-kernfs_rename_ns-to-consider-KERNFS_ST.patch
 0005-kernfs-allow-negative-dentries.patch
 0006-kernfs-add-kernfs_dir_ops.patch

0001-0004 are prepatory patches.

0005 updates kernfs to allow negative dentries.

0006 implements kernfs_dir_ops.

This patchset is based on

  driver-core-next a8b1c0193602 ("Documentation: start documenting driver design patterns")
+ [1] [PATCHSET] kernfs: s/sysfs/kernfs/

and also available in the following git branch.

 git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git review-kernfs-dir_ops

diffstat follows.

 fs/kernfs/dir.c             |  111 ++++++++++++++++++++++++++++++--------------
 fs/kernfs/file.c            |   23 +++++----
 fs/kernfs/kernfs-internal.h |    2
 fs/sysfs/dir.c              |    3 -
 fs/sysfs/file.c             |    4 -
 fs/sysfs/group.c            |    3 -
 fs/sysfs/mount.c            |    2
 include/linux/kernfs.h      |   61 +++++++++++++++---------
 8 files changed, 140 insertions(+), 69 deletions(-)

Thanks.

--
tejun

[1] http://lkml.kernel.org/g/1386789118-24733-1-git-send-email-tj@kernel.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/