linux-kernel - Re: [PATCH] ARM: S3C24XX: Fix configuration of gpio port sizes on S3C24XX.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 13 Dec 2013 09:42:03 +0100
From:	Heiko Stübner <heiko@...ech.de>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	José Miguel Gonçalves <jose.goncalves@...v.pt>,
	Ben Dooks <ben-linux@...ff.org>,
	Kukjin Kim <kgene.kim@...sung.com>,
	Tomasz Figa <t.figa@...sung.com>,
	"linux-samsung-soc" <linux-samsung-soc@...r.kernel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: S3C24XX: Fix configuration of gpio port sizes on S3C24XX.

Am Freitag, 13. Dezember 2013, 09:12:52 schrieb Linus Walleij:
> On Fri, Dec 13, 2013 at 2:55 AM, José Miguel Gonçalves
> 
> <jose.goncalves@...v.pt> wrote:
> > On 27-09-2013 15:17, Linus Walleij wrote:
> >> On Wed, Sep 11, 2013 at 10:46 AM, José Miguel Gonçalves
> >> 
> >> <jose.goncalves@...v.pt> wrote:
> >>> Some GPIO line limits are incorrectly set which, for instance,
> >>> does not allow nRTS1 (GPH11) configuration on a S3C2416 chip.
> >>> 
> >>> Signed-off-by: José Miguel Gonçalves <jose.goncalves@...v.pt>
> >>> ---
> >>> 
> >>>   arch/arm/mach-s3c24xx/include/mach/gpio.h |   10 +++++-----
> 
> (...)
> 
> > Was this patch forgotten?
> 
> Not by me, I just never got an ACK from the Samsung maintainers,
> so I can't apply it to the GPIO tree.
> 
> Ben, Kukjin: can one of you ACK this so I can take it through the
> GPIO tree?

again not the maintainer :-), but I've looked through the manuals of s3c24xx 
socs and the new values look correct [I had looked up the patch content in the 
list archive], so

Acked-by: Heiko Stuebner <heiko@...ech.de>


But Jose, you should really really look into moving to devicetree with your 
platform, if you're not already doing so. Pinctrl support is already present, 
and I'm hopefull the move to the common clock framework I posted a few days 
ago might make it too.


Heiko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/