linux-kernel - Re: [PATCH v2] kernel/locking: mutex: simplify access to the first entry in the wait-list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 13 Dec 2013 15:04:26 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Andrzej Pietrasiewicz <andrzej.p@...sung.com>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	linux-kernel@...r.kernel.org,
	'Marek Szyprowski' <m.szyprowski@...sung.com>,
	'Ingo Molnar' <mingo@...hat.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v2] kernel/locking: mutex: simplify access to the first
 entry in the wait-list


* Andrzej Pietrasiewicz <andrzej.p@...sung.com> wrote:

> Hello Ingo & Peter,
> 
> I added Greg on Cc.
> 
> W dniu 12.12.2013 13:52, Peter Zijlstra pisze:
> >On Thu, Dec 12, 2013 at 09:02:07PM +0900, Kyungmin Park wrote:
> >>
> >>>-----Original Message-----
> >>>From: Peter Zijlstra [mailto:peterz@...radead.org]
> >>>Sent: Thursday, December 12, 2013 8:35 PM
> >>>To: Andrzej Pietrasiewicz
> >>>Cc: linux-kernel@...r.kernel.org; Kyungmin Park; Marek Szyprowski; Ingo
> >>>Molnar
> >>>Subject: Re: [PATCH v2] kernel/locking: mutex: simplify access to the
> >>>first entry in the wait-list
> >>>
> >>>On Thu, Dec 12, 2013 at 12:29:32PM +0100, Andrzej Pietrasiewicz wrote:
> >>>>Use list_first_entry instead of explicitly accessing the first entry
> >>>>with "head".next. The comment one line above becomes obsolete.
> >>>>
> >>>>Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@...sung.com>
> >>>>Signed-off-by: Kyungmin Park <kyungmin.park@...sung.com>
> >>>>---
> 
> For quite a long time I've been sending the same SOB lines to the
> linux-usb list.

They can slip through the cracks - but in the past Linus has 
complained about such SOB sequences so it's a real concern.

SOB has a very specific purpose outlined in 
Documentation/SubmittingPatches, please use Reviewed-by or other 
methods of adding credit to others.

Of course if you write a patch and Kyungmin sends me the patch then 
that signoff sequence is completely valid.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/