linux-kernel - Re: [PATCH 4/4] w1: call put_device if device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 14 Dec 2013 19:17:09 +0400
From:	Evgeniy Polyakov <zbr@...emap.net>
To:	Levente Kurusa <levex@...ux.com>,
	LKML <linux-kernel@...r.kernel.org>
Cc:	GregKH <greg@...ah.com>
Subject: Re: [PATCH 4/4] w1: call put_device if device_register fails

Hi

13.12.2013, 23:23, "Levente Kurusa" <levex@...ux.com>:
> Currently, memsetting and kfreeing the device is bad behaviour.
> The device will have a reference count of 1 and hence can cause trouble
> because it has kfree'd. Proper way to handle a failed device_register
> is to call put_device right after it fails.

Looks good to me, thank you
Greg, please pull it into your treee

> Signed-off-by: Levente Kurusa <levex@...ux.com>

Acked-by: Evgeniy Polyakov <zbr@...emap.net>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/