lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 15 Dec 2013 14:07:34 +0100 From: Michal Malý <madcatxster@...fuk.cz> To: Joe Perches <joe@...ches.com> Cc: dmitry.torokhov@...il.com, linux-kernel@...r.kernel.org, linux-input@...r.kernel.org, elias.vds@...il.com, anssi.hannula@....fi Subject: Re: [RFC] Add ff-memless-next driver On Saturday 14 of December 2013 18:04:02 Joe Perches wrote: > On Sun, 2013-12-15 at 01:19 +0100, Michal Malý wrote: > > diff --git a/drivers/input/ff-memless-next.c > > b/drivers/input/ff-memless-next.c > [] > > > +static inline s32 mlnx_clamp_level(const s32 level) > > +{ > > + return (level > 0x7fff) ? 0x7fff : ((level < -0x7fff) ? -0x7fff : > > level); > > clamp(level, -0x7fff, 0x7fff); > [] > > > +static inline int mlnx_is_conditional(const struct ff_effect *effect) > > +{ > > + return (effect->type == FF_DAMPER) || (effect->type == FF_FRICTION) || > > (effect->type == FF_INERTIA) || (effect->type == FF_SPRING); +} > > Maybe try to run your patch through scripts/checkpatch.pl > > bool? > 80 char line max? (true for the file, not just here) > switch? > switch (effect->type) { > case FF_DAMPER: > case FF_FRICTION: > case FF_INERTIA: > case FF_SPRING: > return true; > } > return false; Okay, thanks for the input. I found a problem regarding effect updating in the code anyway. I'll submit a corrected version of the patch once I'm sure it's fixed. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists