linux-kernel - Re: Regression with suspend resume 5a87182aa21d6d5d306840feab9321818dd3e2a3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 16 Dec 2013 16:58:03 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	Bjørn Mork <bjorn@...k.no>
Cc:	Zdenek Kabelac <zkabelac@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Lan Tianyu <tianyu.lan@...el.com>, jinchoi@...adcom.com,
	Paul Bolle <pebolle@...cali.nl>,
	ziegler@...il.mathematik.uni-freiburg.de,
	"Srivatsa S. Bhat" <srivatsa.bhat@...ux.vnet.ibm.com>,
	jbarnes@...tuousgeek.org, "Rafael J. Wysocki" <rjw@...ysocki.net>
Subject: Re: Regression with suspend resume 5a87182aa21d6d5d306840feab9321818dd3e2a3

Adding Rafael, I though he was there on this mail :)

On 16 December 2013 16:32, Bjørn Mork <bjorn@...k.no> wrote:
> It's both patches in combination.  Interesting case, really :-)

Completed my testing now and yes this happened after your patch
came in. I read your chats somewhere else as well (there are so
many mails, bug reports on this topic, can't give link now.. :))..

I think I know why we are facing issues with these two patches in
at the same time.

- My patch is actually disabling governors at suspend/resume or
hibernation..
- Which makes __cpufreq_governor() a nops routine, which simply
returns zero
- Now with your patch you are disabling the frozen feature which
actually makes cpufreq core to free/allocate policies again on suspend
resume. And so the calls like:

__cpufreq_governor(policy, CPUFREQ_GOV_POLICY_INIT)

end up doing nothing at resume when CPUs start coming up. And so
cpufreq_resume()'s calls to __cpufreq_governor(policy,
CPUFREQ_GOV_START) would start behaving badly.. Which is quite
obvious..

As a summary, after my patch to suspend/resume governors we can't
allow policies to be freed and allocated back.

Its not really a war between my patch versus yours :), but I believe the
right thing to do at this point is to get two patches in for 3.13 as well:

5a87182 cpufreq: suspend governors on system suspend/hibernate
and patch discussed here:
http://www.spinics.net/lists/cpufreq/msg08720.html

To finish this problem as early as possible I tested above two
patches and didn't saw any regressions with suspend/resume or
Hibernation.. And obviously this fixes your issues as well :)

@Rafael: I understand that it would be difficult for you to take these
now for 3.13 but they fix some serious problems reported earlier.
Specially the first patch which everybody thought is the culprit :)

Please see if we can manage to get them in :)

--
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/