linux-kernel - Re: [PATCH 1/2] drivers: sfi: Include appropriate headers in sfi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 17 Dec 2013 08:35:02 -0800
From:	Josh Triplett <josh@...htriplett.org>
To:	Rashika Kheria <rashika.kheria@...il.com>
Cc:	linux-kernel@...r.kernel.org, Len Brown <lenb@...nel.org>,
	sfi-devel@...plefirmware.org
Subject: Re: [PATCH 1/2] drivers: sfi: Include appropriate headers in
 sfi_acpi.c

On Tue, Dec 17, 2013 at 06:02:14PM +0530, Rashika Kheria wrote:
> Include header file include/linux/sfi_acpi.h in sfi_acpi.c because
> function sfi_acpi_table_parse() has its prototype declaration in
> include/linux/sfi_acpi.h. Also, include include/linux/acpi.h because it
> contains declarations necessary for include/linux/sfi_acpi.h.
> 
> This eliminates the following warning in sfi_acpi.c:
> drivers/sfi/sfi_acpi.c:154:5: warning: no previous prototype for ‘sfi_acpi_table_parse’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>

Reviewed-by: Josh Triplett <josh@...htriplett.org>

>  drivers/sfi/sfi_acpi.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/sfi/sfi_acpi.c b/drivers/sfi/sfi_acpi.c
> index f5b4ca5..95023f9 100644
> --- a/drivers/sfi/sfi_acpi.c
> +++ b/drivers/sfi/sfi_acpi.c
> @@ -60,6 +60,8 @@
>  #define pr_fmt(fmt) KMSG_COMPONENT ": " fmt
>  
>  #include <linux/kernel.h>
> +#include <linux/acpi.h>
> +#include <linux/sfi_acpi.h>
>  #include <acpi/acpi.h>
>  
>  #include <linux/sfi.h>
> -- 
> 1.7.9.5
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/