linux-kernel - Re: [PATCH 2/2] drivers: ide: Include appropriate header file in ide-pio-blacklist.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 17 Dec 2013 08:37:51 -0800
From:	Josh Triplett <josh@...htriplett.org>
To:	Rashika Kheria <rashika.kheria@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>, linux-ide@...r.kernel.org
Subject: Re: [PATCH 2/2] drivers: ide: Include appropriate header file in
 ide-pio-blacklist.c

On Tue, Dec 17, 2013 at 04:41:11PM +0530, Rashika Kheria wrote:
> Include appropriate header file include/linux/ide.h in file
> ide-pio-blacklist.c because function ide_scan_pio_blacklist() has it's
> prototype declaration in include/linux/ide.h.
> 
> This eliminates the following warning in ide-pio-blacklist.c:
> drivers/ide/ide-pio-blacklist.c:85:5: warning: no previous prototype for ‘ide_scan_pio_blacklist’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>

Reviewed-by: Josh Triplett <josh@...htriplett.org>

>  drivers/ide/ide-pio-blacklist.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/ide/ide-pio-blacklist.c b/drivers/ide/ide-pio-blacklist.c
> index a8c2c8f8..40e683a 100644
> --- a/drivers/ide/ide-pio-blacklist.c
> +++ b/drivers/ide/ide-pio-blacklist.c
> @@ -7,6 +7,7 @@
>   */
>  
>  #include <linux/string.h>
> +#include <linux/ide.h>
>  
>  static struct ide_pio_info {
>  	const char	*name;
> -- 
> 1.7.9.5
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/