linux-kernel - Re: [PATCH 1/2] drivers: ide: Include appropriate header file in ide-cd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 17 Dec 2013 21:11:42 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Rashika Kheria <rashika.kheria@...il.com>,
	linux-kernel@...r.kernel.org
CC:	Borislav Petkov <bp@...en8.de>,
	"David S. Miller" <davem@...emloft.net>, linux-ide@...r.kernel.org,
	josh@...htriplett.org
Subject: Re: [PATCH 1/2] drivers: ide: Include appropriate header file in
 ide-cd_verbose.c

Hello.

On 12/17/2013 02:08 PM, Rashika Kheria wrote:

> Include appropriate header file ide-cd.h in ide-cd_verbose.c because
> function ide_cd_log_error() has its prototype declaration in ide-cd.h.
> Also, include linux/ide.h because it contains certain declarations
> necessary for including ide-cd.h.

    You should fix "ide-cd.h" if it depends on <linux/ide.h>, not the .c file 
including it.

> This eliminates the following warnings in ide-cd_verbose.c:
> drivers/ide/ide-cd_verbose.c:251:6: warning: no previous prototype for ‘ide_cd_log_error’ [-Wmissing-prototypes]

> Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>

WBR, Sergei


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/