linux-kernel - Re: [PATCH v2] drm/bochs: new driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 18 Dec 2013 09:10:06 +0100
From:	David Herrmann <dh.herrmann@...il.com>
To:	Gerd Hoffmann <kraxel@...hat.com>
Cc:	Dave Airlie <airlied@...il.com>,
	open list <linux-kernel@...r.kernel.org>,
	"open list:DRM DRIVERS" <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH v2] drm/bochs: new driver

Hi

On Wed, Dec 18, 2013 at 8:37 AM, Gerd Hoffmann <kraxel@...hat.com> wrote:
> On Mi, 2013-12-18 at 11:52 +1000, Dave Airlie wrote:
>> On Wed, Dec 18, 2013 at 3:04 AM, Gerd Hoffmann <kraxel@...hat.com> wrote:
>> > DRM driver for (virtual) vga cards using the bochs dispi
>> > interface, such as the qemu standard vga (qemu -vga std).
>> >
>> > Don't bother supporting anything but 32bpp for now, even
>> > though the virtual hardware is able to do that.
>>
>> Hi Gerd,
>>
>> just took a quick look over this and it seems in pretty good shape,
>> the one worry I have is if you've tested with vesafb loaded, since you
>> do some pci_request_regions and fail hard, if vesafb has some of the
>> resources this can end up failing the driver load for no good reason.
>> I haven't verified there is a problem here its just something we've
>> had in the past.
>
> Tested, works.  bochs_pci_probe handles it before calling
> drm_get_pci_dev, simliar to cirrus.

It fails with CONFIG_X86_SYSFB=y and CONFIG_FB_SIMPLE=y. But imho that
should get fixed in sysfb, not the drivers loaded on top.

Thanks
David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/