linux-kernel - Re: [PATCH] silicom: fixed checkpatch issues in bypass.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 18 Dec 2013 16:19:35 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Michael Hoefler <michael.hoefler@...dium.uni-erlangen.de>
Cc:	linux-kernel@...cs.fau.de,
	Christoph Kohl <christoph.kohl@...nline.de>,
	Chad Williamson <chad@...c.us>,
	Randy Dunlap <rdunlap@...radead.org>,
	"open list:STAGING SUBSYSTEM" <devel@...verdev.osuosl.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] silicom: fixed checkpatch issues in bypass.c

On Thu, Dec 19, 2013 at 12:45:09AM +0100, Michael Hoefler wrote:
> This patch cleans up bypass.c of the silicom driver in the staging area. All
> errors and most warnings according to checkpatch.pl should be fixed.
> 
> There are still two warnings left related to too many leading tabs at nested
> blocks. I did not touch this issue because the code needs really some
> refactoring and since i don't have the hardware to test the code. So this patch
> does not change the business logic in any way.
> 
> But we address different types of problems.
> For example:
>  - missing braces
>  - lines over 80 characters
>  - unnecessary forward declarations
>  - assignment in if condition
>  - whitespace stuff
>  - a C++ one line comment
>  - parenthesis at return statements
>  - missing __init and __exit macros

You are doing a lot of different things here, making this hard to
review.

How about splitting this up into at least two different patches, one
that does the code formatting cleanups, and the other the "logical"
changes needed to make codingstyle happy?

Remember, one patch should only do one thing, if you have to list a
series of things a single patch does, that's not good, it should be
split up.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/