linux-kernel - Re: [PATCH] pid: change task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 20 Dec 2013 09:58:46 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Richard Guy Briggs <rgb@...hat.com>
Cc:	linux-kernel@...r.kernel.org, Oleg Nesterov <oleg@...hat.com>
Subject: Re: [PATCH] pid: change task_struct::pid to read-only

On Thu, Dec 19, 2013 at 11:48:26PM -0500, Richard Guy Briggs wrote:
> On 13/12/17, Peter Zijlstra wrote:
> > On Mon, Dec 16, 2013 at 04:03:38PM -0500, Richard Guy Briggs wrote:
> > > task->pid is only ever assigned once (well ok, twice).  For system health and
> > > secure logging confidence, make it const to make it much more intentional when
> > > it is being changed.
> > > ---
> > > 
> > > Peter, as you had suggested, does this approach work for you in terms of making
> > > task_struct::pid a lot more difficult to accidentally change to try to preserve
> > > its integrity?
> > 
> > Yeah, looks good to me.
> 
> Ok, who would carry this patch?  You?  AKPM?  Me?

Andrew seems to be the him who carries PID stuff. I don't think I can make
a case that its scheduler related.

> Any opinions about Oleg's macro idea?

I'm undecided.. on the one hand the macro makes it too easy to change
const stuff, on the other hand it makes it explicit and easily
greppable.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/