linux-kernel - Re: checkpatch.pl error might be false positive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 20 Dec 2013 01:23:52 -0800
From:	Joe Perches <joe@...ches.com>
To:	Josh Triplett <josh@...htriplett.org>
Cc:	Ravi Patel <rapatel@....com>,
	Jesse Brandeburg <jesse.brandeburg@...el.com>,
	Andy Whitcroft <apw@...onical.com>,
	Kumar Sankaran <ksankaran@....com>, Loc Ho <lho@....com>,
	Keyur Chudgar <kchudgar@....com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: checkpatch.pl error might be false positive

On Fri, 2013-12-20 at 01:16 -0800, Josh Triplett wrote:
> Duplicating the regex seems awful.  Could you put it in a variable?

awful is a strong word and I don't have any
issue with the duplication.  Using a variable
is just as confusing as any duplication.

Using a separate test and message for the GPL
vs the FSF bits would likely be better anyway.

You're the original FSF address patch submitter,
fix it as you think appropriate.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/