linux-kernel - Re: [PATCH 1/6] perf report: Use pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 20 Dec 2013 10:32:39 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
Cc:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...nel.org>,
	Namhyung Kim <namhyung.kim@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	Jiri Olsa <jolsa@...hat.com>, David Ahern <dsahern@...il.com>
Subject: Re: [PATCH 1/6] perf report: Use pr_*() functions if possible

On Thu, 19 Dec 2013 10:30:47 -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Dec 19, 2013 at 04:00:06PM +0900, Namhyung Kim escreveu:
>> -	if (verbose > 3)
>> -		perf_session__fprintf(session, stdout);
>> +	if (use_browser == 0) {
>> +		if (verbose > 3)
>> +			perf_session__fprintf(session, stdout);
>>  
>> -	if (verbose > 2)
>> -		perf_session__fprintf_dsos(session, stdout);
>> +		if (verbose > 2)
>> +			perf_session__fprintf_dsos(session, stdout);
>>  
>> -	if (dump_trace) {
>> -		perf_session__fprintf_nr_events(session, stdout);
>> -		return 0;
>> +		if (dump_trace) {
>> +			perf_session__fprintf_nr_events(session, stdout);
>> +			return 0;
>> +		}
>>  	}
>
> This should be in a different patch, one that is related just to
> dump_trace, i.e. if -D, aka dump_trace (right?) is enabled, then
> probably we won't be initializing the TUI/GUI, no?

Yes, the dump_trace will make use_browser = 0.  So I just moved it under
the if (use_browser == 0).

>
> So having a patch that deals just with conversions of fprintf ->
> pr_{err,etc} and another that deals with dump_trace related seems to be
> the best course of action.

Okay, I'll split this into two.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/