linux-kernel - [PATCH 1/2] reset: Mark function as static in core.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 20 Dec 2013 12:05:24 +0100
From:	Philipp Zabel <p.zabel@...gutronix.de>
To:	linux-kernel@...r.kernel.org
Cc:	kernel@...gutronix.de, Pavel Machek <pavel@....cz>,
	Stephen Warren <swarren@...dia.com>,
	Dan Carpenter <dan.carpenter@...cle.com>,
	Rashika Kheria <rashika.kheria@...il.com>,
	Josh Triplett <josh@...htriplett.org>,
	Philipp Zabel <p.zabel@...gutronix.de>
Subject: [PATCH 1/2] reset: Mark function as static in core.c

From: Rashika Kheria <rashika.kheria@...il.com>

This patch marks the function of_reset_simple_xlate() as static in
core.c because it is not used outside this file.

Thus, it also eliminate the following warning in core.c:
drivers/reset/core.c:46:5: warning: no previous prototype for ‘of_reset_simple_xlate’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>
Signed-off-by: Philipp Zabel <p.zabel@...gutronix.de>
---
Left the _put function as is and also removed the EXPORT_SYMBOL_GPL for _xlate.
---
 drivers/reset/core.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/reset/core.c b/drivers/reset/core.c
index b3d99a1..6c80ea6 100644
--- a/drivers/reset/core.c
+++ b/drivers/reset/core.c
@@ -43,8 +43,8 @@ struct reset_control {
  * This simple translation function should be used for reset controllers
  * with 1:1 mapping, where reset lines can be indexed by number without gaps.
  */
-int of_reset_simple_xlate(struct reset_controller_dev *rcdev,
-			  const struct of_phandle_args *reset_spec)
+static int of_reset_simple_xlate(struct reset_controller_dev *rcdev,
+				 const struct of_phandle_args *reset_spec)
 {
 	if (WARN_ON(reset_spec->args_count != rcdev->of_reset_n_cells))
 		return -EINVAL;
@@ -54,7 +54,6 @@ int of_reset_simple_xlate(struct reset_controller_dev *rcdev,
 
 	return reset_spec->args[0];
 }
-EXPORT_SYMBOL_GPL(of_reset_simple_xlate);
 
 /**
  * reset_controller_register - register a reset controller device
-- 
1.8.5.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/