lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Fri, 27 Dec 2013 11:21:04 +0900
From:	Jingoo Han <jg1.han@...sung.com>
To:	'Rashika Kheria' <rashika.kheria@...il.com>,
	'Andrew Morton' <akpm@...ux-foundation.org>
Cc:	'Josh Triplett' <josh@...htriplett.org>,
	linux-kernel@...r.kernel.org,
	'Jean-Christophe Plagniol-Villard' <plagnioj@...osoft.com>,
	'Tomi Valkeinen' <tomi.valkeinen@...com>,
	linux-fbdev@...r.kernel.org, 'Jingoo Han' <jg1.han@...sung.com>,
	'Eric Miao' <eric.y.miao@...il.com>
Subject: Re: [PATCH] drivers: video: Remove unused function
 genericbl_limit_intensity() in generic_bl.c

On Monday, December 16, 2013 11:24 PM, Josh Triplett wrote:
> On Mon, Dec 16, 2013 at 04:51:10PM +0530, Rashika Kheria wrote:
> > Removes unused function genericbl_limit_intensity() in
> > backlight/generic_bl.c.
> >
> > This eliminates the following warning in backlight/generic_bl.c:
> > drivers/video/backlight/generic_bl.c:59:6: warning: no previous prototype for
> ‘genericbl_limit_intensity’ [-Wmissing-prototypes]
> >
> > Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>
> 
> Reviewed-by: Josh Triplett <josh@...htriplett.org>

(+cc Andrew Morton, Eric Miao)

Acked-by: Jingoo Han <jg1.han@...sung.com>

Best regards,
Jingoo Han

> 
> >  drivers/video/backlight/generic_bl.c |   18 ------------------
> >  1 file changed, 18 deletions(-)
> >
> > diff --git a/drivers/video/backlight/generic_bl.c b/drivers/video/backlight/generic_bl.c
> > index 5d8d652..67dfb93 100644
> > --- a/drivers/video/backlight/generic_bl.c
> > +++ b/drivers/video/backlight/generic_bl.c
> > @@ -52,24 +52,6 @@ static int genericbl_get_intensity(struct backlight_device *bd)
> >  	return genericbl_intensity;
> >  }
> >
> > -/*
> > - * Called when the battery is low to limit the backlight intensity.
> > - * If limit==0 clear any limit, otherwise limit the intensity
> > - */
> > -void genericbl_limit_intensity(int limit)
> > -{
> > -	struct backlight_device *bd = generic_backlight_device;
> > -
> > -	mutex_lock(&bd->ops_lock);
> > -	if (limit)
> > -		bd->props.state |= GENERICBL_BATTLOW;
> > -	else
> > -		bd->props.state &= ~GENERICBL_BATTLOW;
> > -	backlight_update_status(generic_backlight_device);
> > -	mutex_unlock(&bd->ops_lock);
> > -}
> > -EXPORT_SYMBOL(genericbl_limit_intensity);
> > -
> >  static const struct backlight_ops genericbl_ops = {
> >  	.options = BL_CORE_SUSPENDRESUME,
> >  	.get_brightness = genericbl_get_intensity,
> > --
> > 1.7.9.5
> >

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ