linux-kernel - [PATCH 2/7] Fix a defined-but-not-used warning for do_gma_backlight

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Fri, 03 Jan 2014 16:07:31 +0000
From:	David Howells <dhowells@...hat.com>
To:	akpm@...ux-foundation.org
Cc:	dhowells@...hat.com, Greg Kroah-Hartman <gregkh@...e.de>,
	linux-kernel@...r.kernel.org, Alan Cox <alan@...ux.intel.com>
Subject: [PATCH 2/7] Fix a defined-but-not-used warning for
 do_gma_backlight_set()

Fix the following warning:

	drivers/gpu/drm/gma500/backlight.c:29:13: warning: 'do_gma_backlight_set' defined but not used [-Wunused-function]

by moving the entire function inside the conditional section currently inside
of it.  All the places that call it are so conditionalised.

Signed-off-by: David Howells <dhowells@...hat.com>
cc: Alan Cox <alan@...ux.intel.com>
cc: Greg Kroah-Hartman <gregkh@...e.de>
---

 drivers/gpu/drm/gma500/backlight.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/gma500/backlight.c b/drivers/gpu/drm/gma500/backlight.c
index 143eba3309c5..d4f79bc3665e 100644
--- a/drivers/gpu/drm/gma500/backlight.c
+++ b/drivers/gpu/drm/gma500/backlight.c
@@ -26,13 +26,13 @@
 #include "intel_bios.h"
 #include "power.h"
 
+#ifdef CONFIG_BACKLIGHT_CLASS_DEVICE
 static void do_gma_backlight_set(struct drm_device *dev)
 {
-#ifdef CONFIG_BACKLIGHT_CLASS_DEVICE
 	struct drm_psb_private *dev_priv = dev->dev_private;
 	backlight_update_status(dev_priv->backlight_device);
-#endif	
 }
+#endif	
 
 void gma_backlight_enable(struct drm_device *dev)
 {

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/