linux-kernel - Re: [PATCH 3.4 22/43] tg3: Expand 4g_overflow_test workaround to skb fragments of any size.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 6 Jan 2014 15:05:39 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	Nithin Nayak Sujir <nsujir@...adcom.com>,
	Michael Chan <mchan@...adcom.com>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH 3.4 22/43] tg3: Expand 4g_overflow_test workaround to skb
 fragments of any size.

On Mon, Jan 06, 2014 at 02:58:55PM -0800, Eric Dumazet wrote:
> On Mon, 2014-01-06 at 14:39 -0800, Greg Kroah-Hartman wrote:
> > 3.4-stable review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Nithin Sujir <nsujir@...adcom.com>
> > 
> > commit 375679104ab3ccfd18dcbd7ba503734fb9a2c63a upstream.
> > 
> > The current driver assumes that an skb fragment can only be upto jumbo
> > size. Presumably this was a fast-path optimization. This assumption is
> > no longer true as fragments can be upto 32k.
> > 
> > v2: Remove unnecessary parantheses per Eric Dumazet.
> > 
> > Signed-off-by: Nithin Nayak Sujir <nsujir@...adcom.com>
> > Signed-off-by: Michael Chan <mchan@...adcom.com>
> > Signed-off-by: David S. Miller <davem@...emloft.net>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > 
> > ---
> >  drivers/net/ethernet/broadcom/tg3.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > --- a/drivers/net/ethernet/broadcom/tg3.c
> > +++ b/drivers/net/ethernet/broadcom/tg3.c
> > @@ -6619,7 +6619,7 @@ static inline int tg3_4g_overflow_test(d
> >  {
> >  	u32 base = (u32) mapping & 0xffffffff;
> >  
> > -	return (base > 0xffffdcc0) && (base + len + 8 < base);
> > +	return base + len + 8 < base;
> >  }
> >  
> 
> Minor comment :
> 
> 32KB frags were added later, in 3.7.
> 
> This patch makes no harm, so no worries.

Ah, thanks, I'll go drop it anyway.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/