linux-kernel - Re: [PATCH] sparc: replace __GFP_NOFAIL with GFP_ATOMIC in mdesc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 7 Jan 2014 10:21:51 +0800
From:	Ethan Zhao <ethan.kernel@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	LKML <linux-kernel@...r.kernel.org>, sparclinux@...r.kernel.org
Subject: Re: [PATCH] sparc: replace __GFP_NOFAIL with GFP_ATOMIC in mdesc_kmalloc()

cc sparclinux@...r.kernel.org

On Wed, Dec 11, 2013 at 10:54 PM, Ethan Zhao <ethan.kernel@...il.com> wrote:
> Has kmalloc() failure checking there, so it is unnecessary to allocate with
> __GFP_NOFAIL flag that might block forever.
>
> Signed-off-by: Ethan Zhao <ethan.kernel@...il.com>
> ---
>  arch/sparc/kernel/mdesc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/sparc/kernel/mdesc.c b/arch/sparc/kernel/mdesc.c
> index b90bf23..e8d678c 100644
> --- a/arch/sparc/kernel/mdesc.c
> +++ b/arch/sparc/kernel/mdesc.c
> @@ -136,7 +136,7 @@ static struct mdesc_handle *mdesc_kmalloc(unsigned int mdesc_size)
>                        sizeof(struct mdesc_hdr) +
>                        mdesc_size);
>
> -       base = kmalloc(handle_size + 15, GFP_KERNEL | __GFP_NOFAIL);
> +       base = kmalloc(handle_size + 15, GFP_KERNEL | GFP_ATOMIC);
>         if (base) {
>                 struct mdesc_handle *hp;
>                 unsigned long addr;
> --
> 1.8.3.4 (Apple Git-47)
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/