linux-kernel - Re: [PATCH v2] phy: kconfig: add depends on "USB_PHY" to OMAP_USB2 and TWL4030

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 7 Jan 2014 15:23:35 +0530
From:	Kishon Vijay Abraham I <kishon@...com>
To:	Aaro Koskinen <aaro.koskinen@....fi>
CC:	<balbi@...com>, <linux@....linux.org.uk>,
	<gregkh@...uxfoundation.org>, <santosh.shilimkar@...com>,
	<linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2] phy: kconfig: add depends on "USB_PHY" to OMAP_USB2
 and TWL4030_USB

On Thursday 26 December 2013 06:35 PM, Aaro Koskinen wrote:
> Hi,
> 
> On Tue, Dec 03, 2013 at 07:38:52PM +0530, Kishon Vijay Abraham I wrote:
>> Fixes
>> warning: (OMAP_USB2 && TWL4030_USB) selects USB_PHY which has unmet
>> direct dependencies (USB_SUPPORT)
>> that shows up while disabling USB_SUPPORT from menuconfig.
> [...]
>>  config TWL4030_USB
>>  	tristate "TWL4030 USB Transceiver Driver"
>>  	depends on TWL4030_CORE && REGULATOR_TWL4030 && USB_MUSB_OMAP2PLUS
>> +	depends on USB_PHY
>>  	select GENERIC_PHY
>> -	select USB_PHY
>>  	help
>>  	  Enable this to support the USB OTG transceiver on TWL4030
>>  	  family chips (including the TWL5030 and TPS659x0 devices).
> 
> This introduced a minor problem in 3.13-rc5: User is no longer able to
> select TWL4030_USB with menuconfig, since there is no menu entry for
> enabling USB_PHY. The only way to enable TWL4030_USB is to enable some
> other option first that happens to select USB_PHY...

huh.. I think we should go back to my v1 [1] or make USB_PHY selectable. I'm
not sure if there is any other way to handle this.

Thanks
Kishon

[1] -> https://groups.google.com/forum/#!topic/linux.kernel/Omf83s4rkwY
> 
> A.
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/