lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 11 Jan 2014 03:30:25 +0000 From: "Brown, Aaron F" <aaron.f.brown@...el.com> To: Ding Tianhong <dingtianhong@...wei.com>, "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>, "Brandeburg, Jesse" <jesse.brandeburg@...el.com>, "Wyborny, Carolyn" <carolyn.wyborny@...el.com>, "Skidmore, Donald C" <donald.c.skidmore@...el.com>, "David S. Miller" <davem@...emloft.net>, Netdev <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: RE: [PATCH net-next v2 06/20] net: igbvf: slight optimization of addr compare > From: netdev-owner@...r.kernel.org [mailto:netdev-owner@...r.kernel.org] > On Behalf Of Ding Tianhong > Sent: Friday, December 27, 2013 10:17 PM > To: Kirsher, Jeffrey T; Brandeburg, Jesse; Wyborny, Carolyn; Skidmore, > Donald C; David S. Miller; Netdev; linux-kernel@...r.kernel.org > Subject: [PATCH net-next v2 06/20] net: igbvf: slight optimization of addr > compare > > Use possibly more efficient ether_addr_equal to instead of memcmp. > > Cc: Jeff Kirsher <jeffrey.t.kirsher@...el.com> > Cc: Jesse Brandeburg <jesse.brandeburg@...el.com> > Cc: Carolyn Wyborny <carolyn.wyborny@...el.com> > Cc: Don Skidmore <donald.c.skidmore@...el.com> > Signed-off-by: Ding Tianhong <dingtianhong@...wei.com> Signed-off-by: Aaron Brown <aaron.f.brown@...el.com> Tested by: Aaron Brown <aaron.f.brown@...el.com> > --- > drivers/net/ethernet/intel/igbvf/netdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/intel/igbvf/netdev.c > b/drivers/net/ethernet/intel/igbvf/netdev.c > index 04bf22e..675435f 100644 > --- a/drivers/net/ethernet/intel/igbvf/netdev.c > +++ b/drivers/net/ethernet/intel/igbvf/netdev.c > @@ -1745,7 +1745,7 @@ static int igbvf_set_mac(struct net_device *netdev, > void *p) > > hw->mac.ops.rar_set(hw, hw->mac.addr, 0); > > - if (memcmp(addr->sa_data, hw->mac.addr, 6)) > + if (!ether_addr_equal(addr->sa_data, hw->mac.addr)) > return -EADDRNOTAVAIL; > > memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len); > -- > 1.8.0 > > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists