linux-kernel - Re: [patch] vlynq: fix another resource size off by 1 error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 12 Jan 2014 11:43:36 -0800
From:	Florian Fainelli <florian@...nwrt.org>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
	Julia Lawall <julia@...u.dk>, apkm@...ux-foundation.org
Subject: Re: [patch] vlynq: fix another resource size off by 1 error

Le lundi 11 novembre 2013, 14:48:27 Dan Carpenter a écrit :
> We still need to apply this fix.

Sorry for this late answer, vlynq changes usually go through AKPM's tree as I 
don't maintain one due to the low number of changes in this code.

> 
> regards,
> dan carpenter
> 
> On Fri, Aug 23, 2013 at 11:19:49AM +0300, Dan Carpenter wrote:
> > We fixed the call to request_mem_region() patch
> > 3354f73 ('drivers/vlynq/vlynq.c: fix resource size off by 1 error').
> > But we need to fix the call the release_mem_region() as well.
> > 
> > Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> > ---
> > Static checker stuff.
> > 
> > diff --git a/drivers/vlynq/vlynq.c b/drivers/vlynq/vlynq.c
> > index 7b07135..c0227f9 100644
> > --- a/drivers/vlynq/vlynq.c
> > +++ b/drivers/vlynq/vlynq.c
> > @@ -762,7 +762,8 @@ static int vlynq_remove(struct platform_device *pdev)
> > 
> >  	device_unregister(&dev->dev);
> >  	iounmap(dev->local);
> > 
> > -	release_mem_region(dev->regs_start, dev->regs_end - dev->regs_start);
> > +	release_mem_region(dev->regs_start,
> > +			   dev->regs_end - dev->regs_start + 1);
> > 
> >  	kfree(dev);
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/