lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 13 Jan 2014 16:22:27 +0800
From:	Ren Qiaowei <qiaowei.ren@...el.com>
To:	Borislav Petkov <bp@...en8.de>, "H. Peter Anvin" <hpa@...or.com>
CC:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, x86@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] x86, mpx: extend siginfo structure to include bound
 violation information

On 01/13/2014 11:09 AM, Ren Qiaowei wrote:
> On 01/13/2014 01:03 AM, Borislav Petkov wrote:
>> On Sun, Jan 12, 2014 at 08:49:21AM -0800, H. Peter Anvin wrote:
>>> I saw a previous version of the code that did that, and it really
>>> didn't work out well -- it ended up being more complex and slower.
>>
>> I suspected as much.
>>
>> But, we still probably should use the generic struct insn, insn_field,
>> etc and act on them in mpx.c instead of defining our own mpx_insn,
>> mpx_insn_field, X86_MODRM_MOD, etc in the header which are more or less
>> copied from insn.h, right?
>>
>
> I tried to use generic structure and macro, but many members of generic
> struct insn are not used for MPX, and except this I have to add one
> member into this structure. So I define mpx specific struct insn.
>
> And so I guess only struct insn_field and several macros like X86_XXX
> may use generic version. Anyway, I will try to use their generic version
> in next version for this patchset.
>
Because only struct insn_field and several macros may be replaced with 
generic version, I guess it maybe be confused easily to include generic 
insn header. What do you think about it?

Thanks,
Qiaowei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ