linux-kernel - Re: [PATCH] drivers/hid/wacom: fixed coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 21 Jan 2014 13:25:54 -0800
From:	Joe Perches <joe@...ches.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	Rob Schroer <sulamiification@...il.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/hid/wacom: fixed coding style issues

On Tue, 2014-01-21 at 13:18 -0800, Dmitry Torokhov wrote:
> On Tue, Jan 21, 2014 at 09:29:44PM +0100, Rob Schroer wrote:
> > As far as I can see, kstrtoXXX() might be an alternative, but I was just
> > fixing coding style issues, no need to break anything IMO.
> 
> You could do the breaking in a follow up patch ;)

Yes please.

Include the breaking of multiple statements
into multiple lines too please like

from:
	case USB_DEVICE_ID_WACOM_GRAPHIRE_BLUETOOTH:
		rep_data[0] = 0x03; rep_data[1] = 0x00;

to:
	case USB_DEVICE_ID_WACOM_GRAPHIRE_BLUETOOTH:
		rep_data[0] = 0x03;
		rep_data[1] = 0x00;


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/