linux-kernel - Re: [PATCH v2 0/4] Intel MPX support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 23 Jan 2014 09:42:17 +0800
From:	Ren Qiaowei <qiaowei.ren@...el.com>
To:	Ingo Molnar <mingo@...nel.org>
CC:	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"x86@...nel.org" <x86@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH v2 0/4] Intel MPX support

On 01/22/2014 08:30 PM, Ingo Molnar wrote:
>
> * Ren, Qiaowei <qiaowei.ren@...el.com> wrote:
>
>>
>>
>>> -----Original Message-----
>>> From: Ingo Molnar [mailto:mingo.kernel.org@...il.com] On Behalf Of Ingo
>>> Molnar
>>> Sent: Wednesday, January 22, 2014 7:53 PM
>>> To: Ren, Qiaowei
>>> Cc: H. Peter Anvin; Thomas Gleixner; Ingo Molnar; x86@...nel.org;
>>> linux-kernel@...r.kernel.org; Peter Zijlstra
>>> Subject: Re: [PATCH v2 0/4] Intel MPX support
>>>
>>>
>>> * Qiaowei Ren <qiaowei.ren@...el.com> wrote:
>>>
>>>> Changes since v1:
>>>>    * check to see if #BR occurred in userspace or kernel space.
>>>>    * use generic structure and macro as much as possible when
>>>>      decode mpx instructions.
>>>>
>>>> Qiaowei Ren (4):
>>>>    x86, mpx: add documentation on Intel MPX
>>>>    x86, mpx: hook #BR exception handler to allocate bound tables
>>>>    x86, mpx: add prctl commands PR_MPX_INIT, PR_MPX_RELEASE
>>>>    x86, mpx: extend siginfo structure to include bound violation
>>>>      information
>>>>
>>>>   Documentation/x86/intel_mpx.txt    |   76 +++++++
>>>>   arch/x86/Kconfig                   |    4 +
>>>>   arch/x86/include/asm/mpx.h         |   63 ++++++
>>>>   arch/x86/include/asm/processor.h   |   16 ++
>>>>   arch/x86/kernel/Makefile           |    1 +
>>>>   arch/x86/kernel/mpx.c              |  417
>>> ++++++++++++++++++++++++++++++++++++
>>>>   arch/x86/kernel/traps.c            |   61 +++++-
>>>>   include/uapi/asm-generic/siginfo.h |    9 +-
>>>>   include/uapi/linux/prctl.h         |    6 +
>>>>   kernel/signal.c                    |    4 +
>>>>   kernel/sys.c                       |   12 +
>>>>   11 files changed, 667 insertions(+), 2 deletions(-)  create mode
>>>> 100644 Documentation/x86/intel_mpx.txt  create mode 100644
>>>> arch/x86/include/asm/mpx.h  create mode 100644 arch/x86/kernel/mpx.c
>>>
>>> Such a patch submission is absolutely inadequate!
>>>
>>> Please outline:
>>>
>>>    - a short summary of what the feature does
>>>
>>>    - a short description of what hardware supports it today or will
>>>      support it in the future
>>>
>>>    - a short description of whether the feature needs any
>>>      configuration from the user or it's entirely auto-enabled on
>>>      hardware that supports it.
>>>
>>>    - a cost/benefit description to unrelated code: is this slowing down
>>>      anything else?
>>>
>>>    - how does user-space compiler support stand, what's the expected
>>>      status there, etc.
>>>
>>> Only a small fraction of that information can be found in
>>> Documentation/x86/intel_mpx.txt. in
>>>
>>> I'm absolutely sick of these semi-anonymous patch submissions from Intel, so
>>> I'm NAK-ing it until it's communicated properly.
>>>
>> Ok. I will add related content into this documentation.
>
> More importantly, put it into the 0/X mail! That's how people can
> review such a patch set effectively.
>
Ok. Thanks for your feedback. I will do it.

Thanks,
Qiaowei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/