linux-kernel - Re: [PATCH] cpusets: Allocate heap only when required

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 24 Jan 2014 02:51:12 -0800 (PST)
From:	David Rientjes <rientjes@...gle.com>
To:	Tejun Heo <tj@...nel.org>
cc:	Li Zefan <lizefan@...wei.com>,
	Viresh Kumar <viresh.kumar@...aro.org>, mingo@...nel.org,
	peterz@...radead.org, linaro-kernel@...ts.linaro.org,
	patches@...aro.org, linux-kernel@...r.kernel.org,
	Cgroups <cgroups@...r.kernel.org>
Subject: Re: [PATCH] cpusets: Allocate heap only when required

On Fri, 24 Jan 2014, Tejun Heo wrote:

> > It's not harmless, if heap_init() fails with -ENOMEM then the write fails 
> > even though it may not be for memory_spread_page or memory_spread_slab, 
> > which is the minority of the callers of this function.
> 
> And depending on details like that would actually be more harmful.
> Please remember that all writes through cgroupfs may fail under very
> high memory pressure.  There's no "this specific set of writes to this
> specific knob isn't affected by memory pressure" guarantee.
> 

Nobody is depending on shit, the patch is removing a completely pointless 
memory allocation in braindead cpuset code.  What you think is "harmful" 
or "more harmful" is irrelevant, but nobody said anything about depending 
on that behavior to do anything.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/