linux-kernel - Re: [PATCH] x86: allocate cpumask during check irq vectors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 24 Jan 2014 21:05:52 -0500
From:	"Chen, Gong" <gong.chen@...ux.intel.com>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org,
	Prarit Bhargava <prarit@...hat.com>
Subject: Re: [PATCH] x86: allocate cpumask during check irq vectors

On Fri, Jan 24, 2014 at 12:11:07PM -0800, Yinghai Lu wrote:
> Date:	Fri, 24 Jan 2014 12:11:07 -0800
> From: Yinghai Lu <yinghai@...nel.org>
> To: "H. Peter Anvin" <hpa@...or.com>
> Cc: Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...e.hu>,
>  linux-kernel@...r.kernel.org, Yinghai Lu <yinghai@...nel.org>, Prarit
>  Bhargava <prarit@...hat.com>
> Subject: [PATCH] x86: allocate cpumask during check irq vectors
> X-Mailer: git-send-email 1.8.4
> 
> Fix warning:
> arch/x86/kernel/irq.c: In function check_irq_vectors_for_cpu_disable:
> arch/x86/kernel/irq.c:337:1: warning: the frame size of 2052 bytes is larger than 2048 bytes
> 
> when NR_CPUS=8192
> 
> We should use zalloc_cpumask_var() instead.
> 
> Signed-off-by: Yinghai Lu <yinghai@...nel.org>
> Cc: Prarit Bhargava <prarit@...hat.com>
> 
> diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c
> index dbb6087..b114ee4 100644
> --- a/arch/x86/kernel/irq.c
> +++ b/arch/x86/kernel/irq.c
> @@ -277,11 +277,14 @@ int check_irq_vectors_for_cpu_disable(void)
>  	unsigned int this_cpu, vector, this_count, count;
>  	struct irq_desc *desc;
>  	struct irq_data *data;
> -	struct cpumask affinity_new, online_new;
> +	cpumask_var_t affinity_new, online_new;
> +
> +	zalloc_cpumask_var(&affinity_new, GFP_KERNEL);
> +	zalloc_cpumask_var(&online_new, GFP_KERNEL);
>  
Hi, Yinghai

The original author Prarit Bhargava had committed a similar
patch and I ever said this function is protected by stop_machine
so GFP_KERNEL is not reliable. It should be GFP_ATOMIC.


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)