linux-kernel - Re: lm90 driver no longer working on PCs in 3.13

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 26 Jan 2014 12:44:38 -0800
From:	Guenter Roeck <linux@...ck-us.net>
To:	Jean Delvare <khali@...ux-fr.org>
CC:	LM Sensors <lm-sensors@...sensors.org>,
	linux-kernel@...r.kernel.org, Mark Brown <broonie@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>, Wei Ni <wni@...dia.com>
Subject: Re: lm90 driver no longer working on PCs in 3.13

Hi Jean,

On 01/26/2014 12:13 PM, Jean Delvare wrote:
> Hi Guenter,
>
> Adding Wei Ni to Cc, as he provided the commit which causes problem.
>
> On Sun, 26 Jan 2014 11:28:16 -0800, Guenter Roeck wrote:
>> Hi,
>>
>> the lm90 driver is no longer working on PCs with the 3.13 kernel ... or at least not without
>> special configuration.
>>
>> This is what I get if I try to instantiate a device on it (max6695):
>>
>> i2c 1-0018: Driver lm90 requests probe deferral
>> i2c i2c-1: new_device: Instantiated device max6695 at 0x18
>>
>> The regulator core always returns -EPROBE_DEFER if the platform does not support devicetree
>> and if the regulator it is looking for does not exist. Since the driver now requires a mandatory
>> regulator (commit 3e0f964f2ad - hwmon: (lm90) Add power control), and the regulator it requests
>> does not exist on a PC, the result is not really surprising. I thought the regulator core would
>> realize that it has to return a dummy regulator, but apparently that is not the case, or I don't
>> know how to configure it.
>>
>> Any idea what I might need to do to get it working ?
>
> Me, I really don't know. I seem to remember I tested Wei's patch set on
> an emulated ADM1032 chip and it was working fine. So maybe it depends
> on the kernel configuration, or something changed on the regulator side
> meanwhile.
>

The regulator code changed with 3.13; the dummy regulator no longer exists,
and the functionality it provided is supposed to be handled automatically.
But that only really works on devicetree based systems and otherwise returns
-EPROBE_DEFER as mentioned above.

Maybe there is some configuration option, or maybe something needs to be
configured from user space. I found neither. In the first case, we should create
a dependency for the LM90 driver; in the latter case, we would have to make sure
that it is well documented (I'd grumble on that, though - it would result in
never ending trouble for us, having to repeatedly explain how this is now
supposed to work).

Another possible fix would be to have the regulator core return -ENODEV
instead of -EPROBE_DEFER on non-dt systems. No idea if this would be acceptable
or even feasible.

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/