linux-kernel - Re: [PATCHSET 00/24] perf tools: Add support to accumulate hist periods (v7)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 27 Jan 2014 15:22:43 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...nel.org>,
	Paul Mackerras <paulus@...ba.org>,
	Namhyung Kim <namhyung.kim@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	Arun Sharma <asharma@...com>,
	Rodrigo Campos <rodrigo@...g.com.ar>,
	Andi Kleen <andi@...stfloor.org>,
	Frederic Weisbecker <fweisbec@...il.com>
Subject: Re: [PATCHSET 00/24] perf tools: Add support to accumulate hist periods (v7)

On Thu, 23 Jan 2014 17:22:48 +0100, Jiri Olsa wrote:
> On Thu, Jan 23, 2014 at 09:13:44AM +0900, Namhyung Kim wrote:
>> 
>>   $ perf report --no-call-graph --children --stdio
>> 
>>   #     Self  Children  Command      Shared Object                 Symbol
>>   # ........  ........  .......  .................  .....................
>>   #
>>        0.00%    91.50%      abc  libc-2.17.so       [.] __libc_start_main
>>        0.00%    91.50%      abc  abc                [.] main             
>>        0.00%    91.50%      abc  abc                [.] c                
>>        0.00%    91.50%      abc  abc                [.] b                
>>       91.50%    91.50%      abc  abc                [.] a                
>>        0.00%     8.18%      abc  ld-2.17.so         [.] _dl_sysdep_start 
>>        8.18%     8.18%      abc  ld-2.17.so         [.] strlen           
>>        0.01%     0.33%      abc  ld-2.17.so         [.] _start           
>>        0.31%     0.31%      abc  [kernel.kallsyms]  [k] page_fault       
>
> I couldnt get this one working:
>
> [jolsa@...va perf]$ ./perf report --no-call-graph --children --stdio
>
> #
> #     Self  Children  Command  Shared Object                      Symbol
> # ........  ........  .......  .............  ..........................
> #
>     94.47%    94.47%      abc  abc            [.] a                     
>      4.74%     4.74%      abc  ld-2.17.so     [.] _dl_map_object_from_fd
>      0.75%     0.75%      abc  ld-2.17.so     [.] _dl_start             
>      0.04%     0.04%      abc  ld-2.17.so     [.] _start                
>
> I was looking for cumulated stdio output without callchain unwinded,
> TUI shows it properly as default

Oops, I missed a change below, sorry.


diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c
index ac658135079f..c1d4ccd755ed 100644
--- a/tools/perf/util/callchain.c
+++ b/tools/perf/util/callchain.c
@@ -538,7 +538,8 @@ int sample__resolve_callchain(struct perf_sample *sample, struct symbol **parent
 	if (sample->callchain == NULL)
 		return 0;
 
-	if (symbol_conf.use_callchain || sort__has_parent) {
+	if (symbol_conf.use_callchain || symbol_conf.cumulate_callchain ||
+	    sort__has_parent) {
 		return machine__resolve_callchain(al->machine, evsel, al->thread,
 						  sample, parent, al, max_stack);
 	}
-- 
1.7.11.7

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/