[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 2 Feb 2014 11:28:22 -0800
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Helge Deller <deller@....de>
Cc: Richard Weinberger <richard.weinberger@...il.com>,
Linux Kernel <linux-kernel@...r.kernel.org>,
Parisc List <linux-parisc@...r.kernel.org>,
James Bottomley <James.Bottomley@...senpartnership.com>,
James Hogan <james.hogan@...tec.com>,
linux-metag@...r.kernel.org
Subject: Re: [GIT PULL] parisc updates for v3.14
On Sun, Feb 2, 2014 at 3:15 AM, Helge Deller <deller@....de> wrote:
>
> Anyway, the suggested & untested patch below should fix the metag arch
> to cope which my changes to fs/exec.c
> ...
> -#define STACK_RND_MASK (0)
> +#define STACK_RND_MASK (-1)
I don't think that works. That completely breaks randomize_stack_top().
So I'm not going to pull the parisc tree, this needs to be resolved sanely.
In fact, I think that change to fs/exec.c is just completely broken:
+ /* add some more stack size for stack randomization */
+ stack_base += STACK_RND_MASK + 1;
and that "+1" just doesn't make sense, and fundamentally breaks STACK_RND_MASK.
It also seems to be entirely pointless, since the PAGE_ALIGN() that
comes right afterwards will effectively do it anyway.
So NAK on that whole fs/exec.c change. Afaik it's just wrong, and it's stupid.
Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists