linux-kernel - Re: [PATCH] staging: bcm: fix pointer-integer size mismatch warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 4 Feb 2014 18:00:47 +0900
From:	SeongJae Park <sj38.park@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Greg KH <gregkh@...uxfoundation.org>, lisa@...apiadmin.com,
	devel@...verdev.osuosl.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: bcm: fix pointer-integer size mismatch warnings

On Tue, Feb 4, 2014 at 5:51 PM, Dan Carpenter <dan.carpenter@...cle.com> wrote:
> On Tue, Feb 04, 2014 at 05:26:57PM +0900, SeongJae Park wrote:
>> Hello,
>>
>> On Tue, Feb 4, 2014 at 5:21 PM, Dan Carpenter <dan.carpenter@...cle.com> wrote:
>> > On Tue, Feb 04, 2014 at 03:59:23PM +0900, SeongJae Park wrote:
>> >> Fix the pointer-integer size mismatch warnings below:
>> >>       drivers/staging/bcm/CmHost.c: In function ‘StoreCmControlResponseMessage’:
>> >>       drivers/staging/bcm/CmHost.c:1387:39: warning: cast to pointer from
>> >>                       integer of different size [-Wint-to-pointer-cast]
>> >>         pstAddIndication->psfAuthorizedSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfAuthorizedSet);
>> >>                                              ^
>> >>       drivers/staging/bcm/CmHost.c:1426:37: warning: cast to pointer from
>> >>                       integer of different size [-Wint-to-pointer-cast]
>> >>         pstAddIndication->psfAdmittedSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfAdmittedSet);
>> >>                                            ^
>> >>       drivers/staging/bcm/CmHost.c:1440:35: warning: cast to pointer from
>> >>                       integer of different size [-Wint-to-pointer-cast]
>> >>         pstAddIndication->psfActiveSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfActiveSet);
>> >>                                          ^
>> >
>> > No.  You haven't fixed the bug, you've just silenced the warning so now
>> > someone has to spent hours and hours looking for it when it comes time
>> > to write a proper fix.  Don't do that.
>> >
>>
>> I had thought silencing warning may be better in someway for some people.
>> But, anyway, now I agree and respect your opinion. Thank you for the opinion :)
>
> Don't worry about it.  You're not the first person to try submit that
> patch.
>
> When I last looked at it, this driver only worked under 32 bits and
> there were other 64 bit bugs as well besides this one.
>
> regards,
> dan carpenter
>

Thank you very much for your kind reply. I'm yet newbie to kernel community
and thinking I should try with unavoidable mistakes. Your reply have gave me
more courage for trial.
I will not forget the learning I got from this trial :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/