linux-kernel - Re: [PATCH 2/2] ALSA: hda/ca0132 - Fix recording from mode id 0x8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 07 Feb 2014 12:05:38 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Hsin-Yu Chao <hychao@...omium.org>
Cc:	linux-arm-kernel@...ts.infradead.org,
	Jaroslav Kysela <perex@...ex.cz>,
	Dylan Reid <dgreid@...omium.org>,
	Chih-Chung Chang <chihchung@...omium.org>,
	Xi Wang <xi.wang@...il.com>,
	Ian Minett <ian_minett@...ativelabs.com>,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] ALSA: hda/ca0132 - Fix recording from mode id 0x8

At Fri,  7 Feb 2014 11:35:30 +0800,
Hsin-Yu Chao wrote:
> 
> The Chromebook Pixel has a microphone under the keyboard that
> is attached to node id 0x8. Before this fix, recording would
> always go to the main internal mic (node id 0x7).
> 
> Signed-off-by: Hsin-Yu Chao <hychao@...omium.org>
> Reviewed-by: Dylan Reid <dgreid@...omium.org>

The description doesn't state why it fixes what: the patch is actually
a fix for the wrong ADC pickup in ca0132_capture_pcm_prepare() where
it assumes wrongly the multiple streams although the driver implements 
one stream per ADC.  (And, ca0132_capture_pcm_cleanup() already does
the right thing.)

Could you rephrase the patch description and resend?


thanks,

Takashi

> ---
>  sound/pci/hda/patch_ca0132.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c
> index 59104dc..d5aabce 100644
> --- a/sound/pci/hda/patch_ca0132.c
> +++ b/sound/pci/hda/patch_ca0132.c
> @@ -2770,9 +2770,7 @@ static int ca0132_capture_pcm_prepare(struct hda_pcm_stream *hinfo,
>  					unsigned int format,
>  					struct snd_pcm_substream *substream)
>  {
> -	struct ca0132_spec *spec = codec->spec;
> -
> -	snd_hda_codec_setup_stream(codec, spec->adcs[substream->number],
> +	snd_hda_codec_setup_stream(codec, hinfo->nid,
>  				   stream_tag, 0, format);
>  
>  	return 0;
> -- 
> 1.9.0.rc1.175.g0b1dcb5
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/