lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 6 Feb 2014 17:48:08 -0800 From: Andrew Chew <AChew@...dia.com> To: Guenter Roeck <linux@...ck-us.net>, "wim@...ana.be" <wim@...ana.be>, "rob@...dley.net" <rob@...dley.net>, "swarren@...dotorg.org" <swarren@...dotorg.org>, "thierry.reding@...il.com" <thierry.reding@...il.com>, "grant.likely@...aro.org" <grant.likely@...aro.org>, "robh+dt@...nel.org" <robh+dt@...nel.org>, "abrestic@...omium.org" <abrestic@...omium.org>, "dgreid@...omium.org" <dgreid@...omium.org>, "katierh@...omium.org" <katierh@...omium.org> CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>, "linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>, "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org> Subject: RE: [PATCH v4 1/1] watchdog: Add tegra watchdog > On 02/06/2014 02:05 PM, Andrew Chew wrote: > > Add a driver for the hardware watchdogs in NVIDIA Tegra SoCs (Tegra30 > > and later). This driver will configure one watchdog timer that will > > reset the system in the case of a watchdog timeout. > > > > This driver binds to the nvidia,tegra30-timer device node and gets its > > register base from there. > > > > Signed-off-by: Andrew Chew <achew@...dia.com> > > --- > > Hi Andrew, > > > + > > + /* This is the timer base. */ > > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > + if (!res) { > > + dev_err(&pdev->dev, "incorrect resources\n"); > > + return -ENODEV; > > + } > > + > > I thought I mentioned that before - dem_iomap_resource() creates the very > same error message and returns an error if NULL is passed as res argument > to it. So the above error message (and error check) is really redundant. Sorry about that. I guess I misunderstood. I'll send a new one out shortly. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists