linux-kernel - Re: [PATCH] staging: ced1401: fix coding style in ced

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 7 Feb 2014 10:01:57 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Pol Eyschen <poleyschen@...il.com>
Cc:	sachin.kamat@...aro.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, ufimtseva@...il.com
Subject: Re: [PATCH] staging: ced1401: fix coding style in ced_ioc.c (resend)

On Wed, Jan 15, 2014 at 10:37:13PM +0100, Pol Eyschen wrote:
> Fixed checkpatch.pl issues and removed redundant comment in ced_ioc.cs
> 
> Signed-off-by: Pol Eyschen <poleyschen@...il.com>
> ---
>  drivers/staging/ced1401/ced_ioc.c |  483 +++++++++++++++++++++----------------
>  1 file changed, 271 insertions(+), 212 deletions(-)
> 
> diff --git a/drivers/staging/ced1401/ced_ioc.c b/drivers/staging/ced1401/ced_ioc.c
> index bf532b1..94a361d 100644
> --- a/drivers/staging/ced1401/ced_ioc.c
> +++ b/drivers/staging/ced1401/ced_ioc.c
> @@ -40,8 +40,8 @@ static void FlushOutBuff(DEVICE_EXTENSION *pdx)
>  {
>  	dev_dbg(&pdx->interface->dev, "%s currentState=%d", __func__,
>  		pdx->sCurrentState);
> -	if (pdx->sCurrentState == U14ERR_TIME)	/* Do nothing if hardware in trouble */
> -		return;
> +	if (pdx->sCurrentState == U14ERR_TIME)
> +		return;	/* Do nothing if hardware in trouble */

That's really not a good cleanup, is it?

And this patch no longer applies to my tree, care to fix it up and
resend?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/