linux-kernel - Re: [PATCH 20/21] fs: Move prototype declaration to header file reiserfs.h from super.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 09 Feb 2014 13:08:50 -0500
From:	Jeff Mahoney <jeffm@...e.com>
To:	Rashika Kheria <rashika.kheria@...il.com>,
	linux-kernel@...r.kernel.org
CC:	Al Viro <viro@...iv.linux.org.uk>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Alex Elder <alex.elder@...aro.org>,
	"David S. Miller" <davem@...emloft.net>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Ionut-Gabriel Radu <ihonius@...il.com>,
	reiserfs-devel@...r.kernel.org, josh@...htriplett.org
Subject: Re: [PATCH 20/21] fs: Move prototype declaration to header file reiserfs.h
 from super.c

On 02/09/2014 08:29 AM, Rashika Kheria wrote:
> Move prototype declaration to header file reiserfs/reiserfs.h from
> reiserfs/super.c because they are used by more than one file.
> 
> This eliminates the following warning in reiserfs/bitmap.c:
> fs/reiserfs/bitmap.c:647:6: warning: no previous prototype for ‘show_alloc_options’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>
> Reviewed-by: Josh Triplett <josh@...htriplett.org>

Acked-by: Jeff Mahoney <jeffm@...e.com>


> ---
>  fs/reiserfs/reiserfs.h |    1 +
>  fs/reiserfs/super.c    |    1 -
>  2 files changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/reiserfs/reiserfs.h b/fs/reiserfs/reiserfs.h
> index 8d06adf..83d4eac 100644
> --- a/fs/reiserfs/reiserfs.h
> +++ b/fs/reiserfs/reiserfs.h
> @@ -2831,6 +2831,7 @@ void reiserfs_init_alloc_options(struct super_block *s);
>   */
>  __le32 reiserfs_choose_packing(struct inode *dir);
>  
> +void show_alloc_options(struct seq_file *seq, struct super_block *s);
>  int reiserfs_init_bitmap_cache(struct super_block *sb);
>  void reiserfs_free_bitmap_cache(struct super_block *sb);
>  void reiserfs_cache_bitmap_metadata(struct super_block *sb, struct buffer_head *bh, struct reiserfs_bitmap_info *info);
> diff --git a/fs/reiserfs/super.c b/fs/reiserfs/super.c
> index 2c80335..16d5335 100644
> --- a/fs/reiserfs/super.c
> +++ b/fs/reiserfs/super.c
> @@ -62,7 +62,6 @@ static int is_any_reiserfs_magic_string(struct reiserfs_super_block *rs)
>  
>  static int reiserfs_remount(struct super_block *s, int *flags, char *data);
>  static int reiserfs_statfs(struct dentry *dentry, struct kstatfs *buf);
> -void show_alloc_options(struct seq_file *seq, struct super_block *s);
>  
>  static int reiserfs_sync_fs(struct super_block *s, int wait)
>  {
> 


-- 
Jeff Mahoney
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/