linux-kernel - Re: [PATCH v5 1/1] drm/i915: Add 180 degree primary plane rotation support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 Feb 2014 23:06:09 +0100
From:	Daniel Vetter <daniel.vetter@...ll.ch>
To:	Sagar Arun Kamble <sagar.a.kamble@...el.com>
Cc:	intel-gfx <intel-gfx@...ts.freedesktop.org>,
	Jani Nikula <jani.nikula@...ux.intel.com>,
	David Airlie <airlied@...ux.ie>,
	dri-devel <dri-devel@...ts.freedesktop.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"Purushothaman, Vijay A" <vijay.a.purushothaman@...el.com>,
	Uma Shankar <uma.shankar@...el.com>
Subject: Re: [PATCH v5 1/1] drm/i915: Add 180 degree primary plane rotation support

On Tue, Feb 11, 2014 at 11:59 AM,  <sagar.a.kamble@...el.com> wrote:
> From: Sagar Kamble <sagar.a.kamble@...el.com>
>
> Primary planes support 180 degree rotation. Expose the feature
> through rotation drm property.
>
> v2: Calculating linear/tiled offsets based on pipe source width and
> height. Added 180 degree rotation support in ironlake_update_plane.
>
> v3: Checking if CRTC is active before issueing update_plane. Added
> wait for vblank to make sure we dont overtake page flips. Disabling
> FBC since it does not work with rotated planes.
>
> v4: Updated rotation checks for pending flips, fbc disable. Creating
> rotation property only for Gen4 onwards. Property resetting as part
> of lastclose.
>
> v5: Resetting property in i915_driver_lastclose properly for planes
> and crtcs. Fixed linear offset calculation that was off by 1 w.r.t
> width in i9xx_update_plane and ironlake_update_plane. Removed tab
> based indentation and unnecessary braces in intel_crtc_set_property
> and intel_update_fbc. FBC and flip related checks should be done only
> for valid crtcs.
>
> Cc: Daniel Vetter <daniel.vetter@...ll.ch>
> Cc: Jani Nikula <jani.nikula@...ux.intel.com>
> Cc: David Airlie <airlied@...ux.ie>
> Cc: dri-devel@...ts.freedesktop.org
> Cc: linux-kernel@...r.kernel.org
> Cc: vijay.a.purushothaman@...el.com
> Signed-off-by: Uma Shankar <uma.shankar@...el.com>
> Signed-off-by: Sagar Kamble <sagar.a.kamble@...el.com>

Process nit: Since you have a nice testcase for this, please add a
reference to it using the testcase tag in the cc/sob section here,
e.g.

Testcase: igt/kms_plane_rotation_crc

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/