linux-kernel - Re: Question about nfs4_destroy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 12 Feb 2014 16:55:02 -0500
From:	Trond Myklebust <trond.myklebust@...marydata.com>
To:	paulmck@...ux.vnet.ibm.com
Cc:	linuxnfs <linux-nfs@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Question about nfs4_destroy_session()


On Feb 12, 2014, at 16:42, Paul E. McKenney <paulmck@...ux.vnet.ibm.com> wrote:

> Hello, Trond,
> 
> In nfs4_destroy_session(), there is an rcu_dereference() that looks to
> leak the returned pointer out of an RCU read-side critical section.
> If the pointed-to object might have just now been created, this is a
> bug because xprt_destroy_backchannel() dereferences this pointer.
> 
> So, does xprt_destroy_backchannel() exclude creation-side code?  (If so,
> no bug -- but a comment might be good.)
> 
> 							Thanx, Paul
> 
> void nfs4_destroy_session(struct nfs4_session *session)
> {
> 	struct rpc_xprt *xprt;
> 	struct rpc_cred *cred;
> 
> 	cred = nfs4_get_clid_cred(session->clp);
> 	nfs4_proc_destroy_session(session, cred);
> 	if (cred)
> 		put_rpccred(cred);
> 
> 	rcu_read_lock();
> 	xprt = rcu_dereference(session->clp->cl_rpcclient->cl_xprt);
> 	rcu_read_unlock();
> 	dprintk("%s Destroy backchannel for xprt %p\n",
> 		__func__, xprt);
> 	xprt_destroy_backchannel(xprt, NFS41_BC_MIN_CALLBACKS);
> 	nfs4_destroy_session_slot_tables(session);
> 	kfree(session);
> }
> 

Hi Paul,

nfs4_destroy_session() is only called when we’re tearing down the struct nfs_client that owns the cl_rppcclient, and the associated cl_xprt, so the code above should be safe, despite being ugly.

Is there a better annotation for use in the above kind of situation?

Cheers,
  Trond

_________________________________
Trond Myklebust
Linux NFS client maintainer, PrimaryData
trond.myklebust@...marydata.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/